Migration to TailwindCSS #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- font moved to index.css - declared variables in tailwind config - declared font in tailwind config - added default styling to base layer - defined themes - default and dark
- can be used to add the default page margin
- in accordance with tailwindCss
- replaced CountUp from external module with own CSS variant
|
It seems like the Compare Macrobench page has a format issue when there is not data/numbers in the tables: EDIT: in fact this also happen in http://localhost/compare?ltag=8d7b507a2a05b5b1ad3ade37233c9ad30a5386e0&rtag=5df2ce4ae0a4e39db4a1eba5d35aa5b6381b1502 |
frouioui
reviewed
Oct 20, 2023
frouioui
reviewed
Oct 23, 2023
frouioui
reviewed
Oct 23, 2023
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
reviewed
Oct 23, 2023
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
reviewed
Oct 23, 2023
frouioui
reviewed
Oct 23, 2023
frouioui
reviewed
Oct 23, 2023
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
reviewed
Oct 23, 2023
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
reviewed
Oct 23, 2023
Comment on lines
+80
to
+87
| <Macrobench | ||
| data={macro} | ||
| gitRef={{ | ||
| left: gitRef.left.slice(0, 8), | ||
| right: gitRef.right.slice(0, 8), | ||
| }} | ||
| commits={{ left: gitRef.left, right: gitRef.right }} | ||
| /> |
There was a problem hiding this comment.
Optimally, we should remove the hyperlinks that redirect to github.com/vitessio/vitess if the git ref is either Left or Right. For instance when reaching http://localhost/compare?ltag=Left&rtag=Right
frouioui
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes commits for migration to tailwindCSS and also a few changes to conventions.
There are also some commits about minor design changes.
A Readme will be added to the website folder for developers to ensure consistency from future contributors.